Skip to content

Avoid runtime WASM compilation when registering the free callback - #248

Open
keyz wants to merge 1 commit into
harfbuzz:mainfrom
keyz:codex/explicit-wasm-initialization
Open

keyz wants to merge 1 commit into
harfbuzz:mainfrom
keyz:codex/explicit-wasm-initialization

Conversation

@keyz

@keyz keyz commented Nov 12, 2026 •

Copy link
Copy Markdown

👋 first time contributor - happy to update/revise as needed!


Wrapping the native free export in a JavaScript callback causes Emscripten to compile a WASM adapter during initialization. This fails when runtime WASM compilation is disabled (in Cloudflare Workers), even if the HarfBuzz module is already instantiated.

Register free directly instead.

@keyz
keyz force-pushed the codex/explicit-wasm-initialization branch from 86d9fdb to ee1e0b7 Compare November 12, 2026 05:11
@keyz
keyz marked this pull request as ready for review November 12, 2026 05:11
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T05:13:40.844623Z ee1e0b7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant