Repository navigation
Conversation
Provider headings were limited to the OpenCode tab, so multi-provider harnesses listed same-name models (e.g. Sonnet via Anthropic, Copilot, and Antigravity) with nothing to tell them apart. - Tag omp/Pi models with their RPC provider and Hermes models with the provider from their `provider:model` id and `Provider:` description, stripping the redundant `<Provider> · ` name prefix. - Group any harness tab whose models carry a provider. - Keep each provider's models contiguous so arrow-key navigation follows the visible order instead of jumping between groups. - Share upstream provider display names across harnesses. Refs hardbeat920#333 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (9)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe changes add shared provider-name helpers, populate provider metadata in Hermes and Pi model records, and group model-picker lists by provider. Tests cover provider metadata and picker ordering. ChangesProvider Metadata and Model Grouping
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The provider-grouped model picker is mergeable after normal checks; no material unresolved behavior is established. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change reorganizes displayed choices while preserving their underlying identities. No new permission or credential path was identified, but selection during simultaneous updates was not fully verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Group models by provider in the omp, Pi, and Hermes tabs, matching the existing OpenCode layout. Keyboard navigation follows the grouped display order, with shared provider labels and redundant Hermes name prefixes removed.
Why
Multi-provider harnesses listed same-name models without identifying their provider. Provider headings make entries such as Sonnet via Anthropic, Copilot, and Antigravity distinguishable.
Refs #333
UI
Before
After
Checklist
npm run checkSummary by CodeRabbit