Skip to content

@hanzo/ui 8.33.1: the providers' row in equal halves no label can widen - #321

Merged
Darkhorse7stars merged 1 commit into
mainfrom
signin-pair-equal
Nov 12, 2026
Merged

Darkhorse7stars merged 1 commit into
mainfrom
signin-pair-equal

Conversation

@Darkhorse7stars

Copy link
Copy Markdown
Member

On live hanzo.ai/login at 1440px, the providers' row ran 3px past the email field. The pair's columns were 1fr 1fr, and a bare 1fr never shrinks below its label. "Continue with Google" needs 197px of a 195px half, so the pair stood 402px against the field's 398, and GitHub's right edge was 3px past the column's.

  • SIGNIN_STYLE: the pair is repeat(2,minmax(0,1fr)), and the one-column fallback under 380px is minmax(0,1fr). Both halves are 194px and flush with the field.
  • The fix reaches every sign-in drawn by these rules: hanzo.ai/login and /signup, hanzo.app's front page, and SignInPanel (hanzo.team).

Checks

  • vitest run src/auth/: 25 passed. The new case pins both column rules to minmax(0,1fr) tracks, and it failed before the change.
  • I swapped the rule in place in the live page's own card stylesheet at 1440px. Before: Google 197px, GitHub 195px, ending at x=923 against the field's 919. After: both 194px, GitHub ending at 919. Each label's content is 192px, so it still fits.

A bare `1fr` keeps its label's width as its floor. On hanzo.ai/login at
1440, "Continue with Google" needs 197px of a 195px half, so the pair
stood 402px against the field's 398 and GitHub ran 3px past the
column's edge. `minmax(0,1fr)` holds both halves at 194px, flush with
the field, and each label still fits.
@Darkhorse7stars
Darkhorse7stars merged commit 6c8df37 into main Nov 12, 2026
19 of 21 checks passed
@Darkhorse7stars
Darkhorse7stars deleted the signin-pair-equal branch November 12, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant