Repository navigation
@hanzo/ui 8.33.1: the providers' row in equal halves no label can widen - #321
Merged
Merged
Conversation
A bare `1fr` keeps its label's width as its floor. On hanzo.ai/login at 1440, "Continue with Google" needs 197px of a 195px half, so the pair stood 402px against the field's 398 and GitHub ran 3px past the column's edge. `minmax(0,1fr)` holds both halves at 194px, flush with the field, and each label still fits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On live hanzo.ai/login at 1440px, the providers' row ran 3px past the email field. The pair's columns were
1fr 1fr, and a bare1frnever shrinks below its label. "Continue with Google" needs 197px of a 195px half, so the pair stood 402px against the field's 398, and GitHub's right edge was 3px past the column's.SIGNIN_STYLE: the pair isrepeat(2,minmax(0,1fr)), and the one-column fallback under 380px isminmax(0,1fr). Both halves are 194px and flush with the field.SignInPanel(hanzo.team).Checks
vitest run src/auth/: 25 passed. The new case pins both column rules tominmax(0,1fr)tracks, and it failed before the change.