Repository navigation
@hanzo/ui 8.32.3: the sign-in panel stands on its own card, coloured by the site - #316
Merged
Merged
Conversation
…by the site SignInPanel was drawn straight on the page, and on hanzo.team the dot field showed through the providers' tinted buttons and the field, so the panel was hard to read. It now stands on a card: a solid ground ($background) inside a 1px hairline ($borderColor), a 12px corner and a 24px inset. - background, borderColor: the site's colours for the card, a theme token ($panel) or any CSS colour. - bare: no card, for a host that sets the panel in a card of its own. A test reads the card's ground and hairline, a site's own colours, and none when bare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SignInPanelwas drawn straight on the page. On hanzo.team the dot field showed through the providers' tinted buttons and the email field, so the panel was hard to read.It now stands on a card: a solid ground (
$background) inside a 1px hairline ($borderColor), a$6corner and a$6inset.background,borderColor: the site's colours for the card, a theme token ($panel) or any CSS colour.bare: no card, for a host that sets the panel in a card of its own.Checks:
signin-panel.test.tsx9/9 (new: the card's ground and hairline, a site's own colours, none when bare); no type errors insrc/auth.hanzo.team picks it up with
@hanzo/ui8.32.3 (hanzoai/team), then@hanzo/teamin hanzo-inc/team.