Repository navigation
@hanzo/ui 8.32.2: @hanzo/ui/auth/panel, the sign-in panel without the in-place form - #315
Merged
Merged
Conversation
… in-place form hanzo.team (Vite) failed to build from @hanzo/ui/auth: the auth barrel also loads SignIn, the in-place form, which imports SecondFactor from a newer @hanzo/iam than hanzo.team's and HanzoMark from @hanzogui/shell, an optional peer it does not install. Rolldown binds every imported name and refused both, though the site draws only SignInPanel. ./auth/panel exports SignInPanel and handoff alone. Their import graph reaches neither SignIn, onboarding nor @hanzogui/shell, and a test keeps it so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
hanzoai/team's publish failed to build after switching to
SignInPanel(hanzoai/team#5):Importing from
@hanzo/ui/authalso loadsSignIn(the in-place form). That form needs a newer@hanzo/iamthan hanzo.team's 0.21.18 and@hanzogui/shell, an optional peer hanzo.team does not install. The bundler binds every imported name and stops the build.What
@hanzo/ui/auth/panel(src/auth/panel.ts): exportsSignInPanelandhandoffalone. Their import graph (27 files) reaches neitherSignIn, onboarding nor@hanzogui/shell.Testing
vitest run src/auth/signin-panel.test.tsx: 8 passed.dist.test.tschecks the new exports entry resolves after the build (CI).