Repository navigation
@hanzo/ui 8.32.1: SignInPanel takes the site's own IAM client - #314
Merged
Merged
Conversation
8.32.0's panel read its client from useIam(), which throws outside an <IamProvider>. hanzo.team holds its own IAM client and mounts no provider, so it could not draw the panel. A `request` prop now takes the function that mints the site's own authorize request (its client's getSigninUrl, which keeps the PKCE verifier and state on the site); under a provider, with no `request`, the provider's client mints it as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
8.32.0's
SignInPanel(#313) reads its client fromuseIam(), which throws outside an<IamProvider>. hanzo.team (Vite) holds its own IAM client and mounts no provider, so it cannot draw the panel.What
request: the function that mints the site's own authorize request (its client'sgetSigninUrl; PKCE verifier and state stay on the site).request, under a provider, the provider's client mints it as before (hanzo-inc/app unchanged).Testing
vitest run src/auth/signin-panel.test.tsx: 7 passed, including a new case where the site passes its own client and an email leaves forhanzo.ai/loginwithlogin_hint.tsc: no errors in the panel files.