Repository navigation
fix(consent): @hanzo/ui 8.33.4, the cookie bar's × centred on its line (v0.1.22) - #16
Merged
Merged
Conversation
…e (v0.1.22) hanzo.team's cookie notice hung its × 7px below the words, its foot 1px past the bar's edge, and on a phone the words ran into it. @hanzo/ui 8.33.4 (hanzoai/ui#322) floors the words' line at the ×'s box, so the × is centred on it (measured: 0px off, 13px inside the bar's foot, 8px clear of the words at 390). The pin moves from 8.32.4, so 8.33.0 to 8.33.3 come along: the only visible change on the signed-out pages is the Google/GitHub row in equal halves (about 2px). @hanzo/team 0.1.22 so hanzo-inc/team can pin it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
hanzo.team's cookie notice (
@hanzo/ui/consent, mounted insrc/app.tsx) had its × off. Measured on this repo's build with the global rule:The cause is in @hanzo/ui. It was fixed and released as 8.33.4 in hanzoai/ui#322.
What changed
@hanzo/ui8.32.4 → 8.33.4;pnpm-lock.yamlregenerated (also@hanzo/tokens1.1.1 → 1.1.3).@hanzo/team0.1.21 → 0.1.22, so merging publishes a version hanzo-inc/team can pin. hanzo.team updates once hanzo-inc/team bumpssite/package.json.After the bump, the × is centred on the text (0px off) and 13px inside the bar's foot. At 390px the text stops 8px before it.
What else the jump brings
8.33.0–8.33.3 come along: the sign-in card and providers row, plus the monochrome and neutral releases. I screenshotted
/,/loginand/issuesoffline, at 1280 (light and dark) and 390, before and after, and diffed the pixels. The only change outside the cookie bar is the Continue with Google / GitHub row, now in equal halves (8.33.1), which moves the buttons by about 2px. The rest of the diff is the hero's typing animation. No colour change shows on these pages. Signed-in screens weren't compared.Checks (local)
pnpm run typecheck: 0 errors (0 before).pnpm test: 75/75 (75/75 before).pnpm run build: OK,dist/index.htmlpresent.🤖 Generated with Claude Code