Repository navigation
Open the workbench after starting page generation - #59
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creating a page with a usable model started generation on the server but then returned to
the page list. It now opens the workbench directly, so the user sees the conversation and
live generation where they can steer it.
Changes
AiPageBuilderEditorafter the background run is admitted instead ofAiPageBuilderPages.aiPrompt/aiModelin that case: the editor reattaches to the existing runthrough
pageChat.activeRun, so the prompt is never submitted twice.prompt preserved, and an unknown outcome opens the editor without resubmitting.
useRouteusage from the create panel.import-page.spec.tsandai-create.spec.ts.Notes
Background runs, admission, and the page list's run status/stop controls are unchanged;
only the destination after a successful start changed.
Validation
pnpm --dir ui type-checkpnpm --dir ui test:unit --run(335 tests passed)