Skip to content

Open the workbench after starting page generation - #59

Merged
ruibaby merged 1 commit into
mainfrom
fix/create-page-open-workbench
Oct 28, 2026
Merged

ruibaby merged 1 commit into
mainfrom
fix/create-page-open-workbench

Conversation

@ruibaby

@ruibaby ruibaby commented Oct 26, 2026

Copy link
Copy Markdown
Member

Summary

Creating a page with a usable model started generation on the server but then returned to
the page list. It now opens the workbench directly, so the user sees the conversation and
live generation where they can steer it.

Changes

  • Navigate to AiPageBuilderEditor after the background run is admitted instead of
    AiPageBuilderPages.
  • Do not pass aiPrompt/aiModel in that case: the editor reattaches to the existing run
    through pageChat.activeRun, so the prompt is never submitted twice.
  • Keep the existing fallbacks — a definite 404 start failure still opens the editor with the
    prompt preserved, and an unknown outcome opens the editor without resubmitting.
  • Drop the now-unused useRoute usage from the create panel.
  • Update the create-flow assertions in import-page.spec.ts and ai-create.spec.ts.

Notes

Background runs, admission, and the page list's run status/stop controls are unchanged;
only the destination after a successful start changed.

Validation

  • pnpm --dir ui type-check
  • pnpm --dir ui test:unit --run (335 tests passed)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T15:31:57.901204Z eae3047 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ruibaby
ruibaby merged commit 1c100a4 into main Oct 28, 2026
1 check passed
@ruibaby
ruibaby deleted the fix/create-page-open-workbench branch October 28, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant