Skip to content

Fix theme source lookup failures and clarify tool errors - #57

Merged
ruibaby merged 1 commit into
mainfrom
fix/theme-source-error-recovery
Oct 26, 2026
Merged

ruibaby merged 1 commit into
mainfrom
fix/theme-source-error-recovery

Conversation

@ruibaby

@ruibaby ruibaby commented Oct 26, 2026

Copy link
Copy Markdown
Member

Missing theme source paths can throw NoSuchFileException and terminate an AI
generation instead of returning a recoverable tool error. The chat then shows
an unfinished tool without explaining the failure.

Return recoverable errors for missing source paths and guide the model to
discover actual paths with list_theme_files. Failures resolving the installed
theme directory still propagate.

Show complete tool errors directly in both live and restored conversations.
Provide a fallback when error details are unavailable and point users to
AI Foundation usage records for unexplained generation failures.

Reproduction and verification:

  • Use a theme containing templates/page.html but no templates/header.html.
  • Read or search the missing file, or list a missing directory.
  • Before this fix, these operations throw NoSuchFileException.
  • Regression tests verify that the same working copy can now discover an
    existing file, read it, and stage an edit after the recoverable error.

Validation:

  • 70 focused backend tests passed.
  • 40 frontend tests passed.
  • Vue/TypeScript type checking and production UI build passed.
  • git diff --check passed.
  • The actual chat component was checked in an isolated browser harness at
    desktop and 390px widths; errors remain visible without horizontal overflow.

The fix has not been deployed or validated through a real-model Halo session.

Visible theme source error details

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T04:59:24.616093Z d8fcf74 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ruibaby
ruibaby merged commit e4c92c8 into main Oct 26, 2026
1 check passed
@ruibaby
ruibaby deleted the fix/theme-source-error-recovery branch October 26, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant