mem: select HBMCtrl pseudo-channels from their address ranges - #10
Open
Basemism wants to merge 1 commit into
Open
mem: select HBMCtrl pseudo-channels from their address ranges#10Basemism wants to merge 1 commit into
Basemism wants to merge 1 commit into
Conversation
HBMCtrl previously selected a pseudo-channel using address bit 6. That assumption breaks when the configured interleave granularity differs from a 64-byte cache line and can route requests, including atomics, to an interface that does not own their address. Select the destination by querying each DRAM interface's address range and panic when neither interface owns the request. This makes pseudo-channel routing follow the ranges constructed by the memory configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBMCtrl previously selected a pseudo-channel using address bit 6. That assumption breaks when the configured interleave granularity differs from a 64-byte cache line and can route requests, including atomics, to an interface that does not own their address.
Select the destination by querying each DRAM interface's address range and panic when neither interface owns the request. This makes pseudo-channel routing follow the ranges constructed by the memory configuration.