Repository navigation
Add caret and draggable text selection handles to chat bubbles - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat text had no caret or draggable endpoints, and double-click selected the whole message. Clicking now places a visible caret, double-click selects a word, and either selection handle can adjust the range. Shift+arrow/Shift+click extend selection; Select All and the separate full-message copy action remain available.
Touch long-press on a message body or caption starts word selection. Handle drags own their gesture so the timeline does not scroll, while normal swipes still scroll and normal link taps still work. The message remains read-only.
Pins the small Makepad selection-geometry API change in OctoSense-org/makepad#114.
Validation:
Makepad widget-library tests: 291 passed, 3 failed on both this change and the unchanged
e9b9f0a6bbaseline. The identical pre-existing failures aredesktop_style::tests::mobile_typefaces_keep_symbol_fallbacks_across_appearances,widget_tree::tests::test_observe_and_find_single_node, andwidget_tree::tests::test_property_patch_no_structural_rebuild.