Move browser authentication to HCA OIDC - #1530
Draft
skyfallwastaken wants to merge 2 commits into
Draft
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Hackatime currently has separate HCA, Slack and email sign-in paths. Their email and Slack claims can drift, which makes automatic legacy account matching unsafe and leaves Hackatime responsible for more authentication code than necessary.
Describe your changes
login_hint. Slack OAuth is limited to legacy recovery or reauthorisation after a recent HCA sign-in and cannot switch the signed-in user.Production identity audit
A read-only current-claim audit checked all 31,784 stored HCA credentials. Of 26,905 valid credentials, 46 distinct HCA identities had a cross-provider ownership conflict. The remaining 4,879 credentials were invalid or expired and could not be checked. No individual identity data or credentials were retained.
Rollout blockers
Do not merge or deploy this PR until all of the following are complete:
HCA_CLIENT_ID,HCA_CLIENT_SECRETand eitherHCA_REDIRECT_URIorPUBLIC_URLconfigured. The registered callback must be/auth/hca/callbackon the production origin.Screenshots / Media