Skip to content

Feat: Support data buffers in tables (same as plots) #2356 - #2509

Closed
Cameron-Nann-Python wants to merge 6 commits into
h2oai:mainfrom
Cameron-Nann-Python:open-source-contribution
Closed

Cameron-Nann-Python wants to merge 6 commits into
h2oai:mainfrom
Cameron-Nann-Python:open-source-contribution

Conversation

@Cameron-Nann-Python

Copy link
Copy Markdown

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

Closes #2356

Updated wavegen.ts to include PackedRecords for Data
Updated frontend table.tsx to account for new rows
Generated new ui.py and types.py files
Updated _guard_enum() in wavegen.ts to accept Optional[str].
Verified both generated types.py files have no errors.
Restored template files
git diff --check passes.
Changed dump function for data buffer in table.py

Changed unpack<TableRow> to accommodate data buffer
Added new template to project templates to demonstrate data buffer functionality
Added template to wave init command to be selected in client.
@Cameron-Nann-Python

Copy link
Copy Markdown
Author

Accidently sent to main repository instead of fork. This was more experimental as a solution is not congruent with the current repository setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support data buffers in tables (same as plots)

1 participant