Skip to content

Stabilize collection cleanup E2E and preserve release artifacts - #140

Merged
henderkes merged 2 commits into
mainfrom
copilot/fix-leave-button-click-timeout
Sep 10, 2026
Merged

henderkes merged 2 commits into
mainfrom
copilot/fix-leave-button-click-timeout

Conversation

Copilot AI commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

The collections E2E suite was flaking because cleanup tried to click a visible Leave button before it became interactable. The rolling release workflow was also deleting downloaded artifacts by checking out the repo after populating dist/, which broke version stamping.

  • E2E cleanup timing

    • Update removeAllCollections() to wait for the first Leave button to become enabled before clicking.
    • Give the click a bounded explicit timeout so cleanup tolerates slower UI state transitions.
  • Release artifact preservation

    • Reorder the rolling release job so actions/checkout runs before actions/download-artifact.
    • Keep dist/ intact for the subsequent slopterm-version.txt stamp and release asset upload.
const leave = page.getByRole('button', { name: 'Leave' }).first()
if (!(await leave.isVisible().catch(() => false))) return
await expect(leave).toBeEnabled({ timeout: 15_000 })
await leave.click({ timeout: 15_000 })

Co-authored-by: henderkes <7896469+henderkes@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix timeout on clicking leave button in removeAllCollections Stabilize collection cleanup E2E and preserve release artifacts Sep 10, 2026
Copilot AI requested a review from henderkes September 10, 2026 22:22
@henderkes
henderkes marked this pull request as ready for review September 10, 2026 22:27
@henderkes
henderkes merged commit bd7a7f5 into main Sep 10, 2026
2 checks passed
@henderkes
henderkes deleted the copilot/fix-leave-button-click-timeout branch September 10, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants