Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds repository artifact cleanup for stale
node_modules, Rusttarget, separately risky Node build output, and explicitly opted-in Gobin/dist. Selected artifacts are checked again before deletion or backup, so a preview cannot authorize a replaced, newly tracked, excluded, or recently active candidate.Type of change
Related issue
None linked.
Checklist
bun run lintpasses (root and desktop source)bun run test:coveragepasses: 539 tests across 56 files; all existing coverage thresholds metbun run buildsucceedsbun run typecheckpassbun run testpasses: 46 tests across 6 files; desktop build succeedsgit diff --checkpassNotes for reviewer
Implementation and acceptance evidence are recorded in execution.yaml. The accompanying PRD, decisions, and audit preserve the design rationale and historical findings.
Fixture benchmarks measured approximately 64 ms / 549 ms / 3.63 s for 30 / 300 / 1,500 candidates. Overlapping roots did not duplicate candidate inspection; Git query counts scale with worktree batches. These are single ordered samples with cache/order effects, not production throughput guarantees.
Filesystem/Git validation remains non-atomic, byte counts are logical estimates, and ambiguous generic outputs in non-Git projects intentionally remain ineligible. Cleanup tests touched temporary fixtures only; external-tool cleanup was mocked.