Repository navigation
feat: Mac Cleaner menu bar desktop app - #90
Merged
Merged
Conversation
Adds desktop/, an Electron menu bar app built on the CLI scanners: - Tray icon in the macOS menu bar with a popover UI (no Dock icon) - Daily automatic clean of non-risky categories at a configurable time, catching up on wake when the Mac was asleep - Clean Now, plus Deep Clean with a scan preview and explicit confirmation before permanently deleting - Run history with space freed per category, notifications, launch at login and Full Disk Access guidance - Packaging to .dmg/.zip (arm64 + x64) with optional signing/notarization, built and attached to releases by a new Desktop App workflow Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QnDqAyRdicRYnwAAXydYoB
Replace the broom artwork with a minimal mint sparkle mark on a light squircle for the app icon, a matching template icon for the menu bar (tuned to stay legible at 16pt) and the popover header logo. Icons are now drawn entirely by scripts/make-icons.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QnDqAyRdicRYnwAAXydYoB
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8be49492a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… bar icon Review fixes: - Deep Clean no longer rescans on its own when the preview is stale or missing categories: it refuses with StaleScanError and the UI goes back to the scan step, so nothing is deleted without being shown first - Keep a persisted lifetime "freed so far" total instead of deriving it from the capped history (older state files are migrated from history) - Show run-level scan errors in the run breakdown and history instead of reporting "Nothing needed to be removed" Icon: the menu bar template is now an outlined sparkle in the style of SF Symbols (18pt, @1x/@2x), and branding/ has transparent PNGs of the mark (colored, and menu bar black/white). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QnDqAyRdicRYnwAAXydYoB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Mac Cleaner, a downloadable macOS menu bar app in
desktop/. It is built with Electron and bundles the CLI's scanners straight from../src, so the categories, safety levels and protected-path checks are the same as the CLI's.LSUIElement). The app icon uses the same mint sparkle on a light squircle. All icons are generated bydesktop/scripts/make-icons.py.temp-files,browser-cache,homebrew,system-logs. You can change them in Settings, but risky categories are blocked in the main process.Packaging: electron-builder produces
.dmgand.zipfiles for arm64 and x64. The build is ad-hoc signed by default. It is signed and notarized automatically when the optional secrets are set (listed indesktop/README.md). The new.github/workflows/desktop.ymlworkflow builds on macOS, uploads the artifacts, and attaches them to GitHub releases.The root
lintscript now also coversdesktop/src.Type of change
Related issue
N/A
Checklist
bun run lintpassesbun run testpasses (no regressions): 344 root tests, plus 38 new desktop tests (scheduler, settings validation, store, clean engine, controller)bun run buildsucceeds (CLI and desktop bundle).dmgis built by the macOS CI job.Notes for reviewer
desktop/README.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01QnDqAyRdicRYnwAAXydYoB