Skip to content

🎛️ Techdebt/test xcode cloud#101

Merged
kcw-grunt merged 5 commits into
developfrom
techdebt/test-xcode-cloud
Apr 26, 2026
Merged

🎛️ Techdebt/test xcode cloud#101
kcw-grunt merged 5 commits into
developfrom
techdebt/test-xcode-cloud

Conversation

@kcw-grunt

@kcw-grunt kcw-grunt commented Apr 19, 2026

Copy link
Copy Markdown
Collaborator

📱 Description

This PR addresses technical debt by improving Xcode Cloud test compatibility and CI/CD reliability. It adds early exit handling in AppDelegate for unit test environments, refactors Firebase configuration setup to be more robust in CI/test scenarios, removes a flaky async test, and updates test plans and CI scripts to support Xcode Cloud pipelines.

🤖 _Auto-generated by Claude

Platform

  • iOS

🎯 Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🔧 Refactoring (code change that neither fixes a bug nor adds a feature)
  • 📚 Documentation update
  • 🎨 UI/UX improvement
  • ⚡ Performance improvement
  • 🧪 Test addition or improvement
  • ⚙️ CI/CD change

📋 Changes

New Components Added

  • None

Modifications

  • AppDelegate.swift: Added IS_RUNNING_UNIT_TESTS environment check for early return; reorganized Firebase initialization order and improved stub configuration with bundleID parameter for test environments; disabled Crashlytics collection in non-production paths
  • SceneTests.swift: Removed flaky async test testDidMoveToView_CallsMakeDot() that used DispatchQueue timing and was prone to race conditions
  • brainwalletUnitTests.xctestplan: Updated test plan configuration for Xcode Cloud compatibility
  • brainwallet.xcscheme & brainwallet-Dutch.xcscheme: Updated scheme configurations for CI/test execution
  • project.pbxproj: Updated Xcode project file to reflect scheme and test plan changes
  • Localizable.xcstrings: String localization updates
  • ci_scripts/ci_post_xcodebuild.sh: Added post-build CI script for Xcode Cloud pipeline

Removals

  • SceneTests.swift: Removed testDidMoveToView_CallsMakeDot() test method (flaky async test relying on timing)

📊 Statistics

  • Additions: 158 lines
  • Deletions: 44 lines
  • Files Changed: 8
  • Commits: 5

🔗 Related Issues

  • Fixes #
  • Related to #

🧪 Tests Status

  • Tests ran successfully locally?
  • Added or updated unit tests?
  • Added or updated UI tests?
  • Code coverage percentage of the codebase: __%

📸 Screenshots/Videos

Before After
Add screenshot Add screenshot

🎯 Reviewers

@kcw-grunt


Draft Status: This PR is currently in draft mode and ready for review feedback.

@kcw-grunt
kcw-grunt requested a review from josikie April 19, 2026 22:19
@kcw-grunt kcw-grunt self-assigned this Apr 19, 2026
@kcw-grunt kcw-grunt changed the title Techdebt/test xcode cloud 🎛️ Techdebt/test xcode cloud Apr 19, 2026
@gruntsoftware gruntsoftware deleted a comment from github-actions Bot Apr 19, 2026
@kcw-grunt
kcw-grunt merged commit ffcf0a6 into develop Apr 26, 2026
2 of 6 checks passed
@kcw-grunt
kcw-grunt deleted the techdebt/test-xcode-cloud branch May 3, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant