Techdebt/modules update#235
Merged
Merged
Conversation
moved to the proper module
Added the sound
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📱 Description
This PR updates module dependencies and includes technical debt improvements to the MainViewModel and BalanceBentoScreen. Key changes include refactoring BigDecimal conversions for improved precision in balance calculations, fixing currency entity matching logic, removing Firebase Crashlytics logging calls, and adding audio feedback when toggling between fiat and LTC display.
Platform
🎯 Type of Change
📋 Changes
New Components Added
boingspringmouthharp042013.mp3– sound effect for fiat/LTC currency toggle.gitmodules– module dependency updatesModifications
MediaPlayerinstance for audio feedback; triggers sound on currency swap toggle actionselectedCurrencyrate from-1fto0ffor USD initializationtoDouble()to directBigDecimal(Long)constructor with proper scale and rounding mode; enhanced currency matching to check both code and symbol; addedselectedCurrencyentity update in state; removed Firebase Crashlytics logging and associated importsRemovals
FirebaseCrashlyticsimport from MainViewModel📊 Statistics
🔗 Related Issues
🧪 Tests Status
📸 Screenshots/Videos
🎯 Reviewers
@kcw-grunt, @josikie
Draft Status: This PR is currently in draft mode and ready for review feedback.