Skip to content

Techdebt/modules update#235

Merged
kcw-grunt merged 3 commits into
developfrom
techdebt/modules-update
Jun 6, 2026
Merged

Techdebt/modules update#235
kcw-grunt merged 3 commits into
developfrom
techdebt/modules-update

Conversation

@kcw-grunt

@kcw-grunt kcw-grunt commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

📱 Description

This PR updates module dependencies and includes technical debt improvements to the MainViewModel and BalanceBentoScreen. Key changes include refactoring BigDecimal conversions for improved precision in balance calculations, fixing currency entity matching logic, removing Firebase Crashlytics logging calls, and adding audio feedback when toggling between fiat and LTC display.

Platform

  • Android

🎯 Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🔧 Refactoring (code change that neither fixes a bug nor adds a feature)
  • 📚 Documentation update
  • 🎨 UI/UX improvement
  • ⚡ Performance improvement
  • 🧪 Test addition or improvement

📋 Changes

New Components Added

  • Audio resource: boingspringmouthharp042013.mp3 – sound effect for fiat/LTC currency toggle
  • Updated .gitmodules – module dependency updates

Modifications

  • BalanceBentoScreen.kt – Added MediaPlayer instance for audio feedback; triggers sound on currency swap toggle action
  • MainScreenState.kt – Changed default selectedCurrency rate from -1f to 0f for USD initialization
  • MainViewModel.kt – Refactored balance conversion from toDouble() to direct BigDecimal(Long) constructor with proper scale and rounding mode; enhanced currency matching to check both code and symbol; added selectedCurrency entity update in state; removed Firebase Crashlytics logging and associated imports
  • app/src/main/jni/core – Native module update (details truncated in diff)
  • modules/bw-gdlib – Module dependency update

Removals

  • Firebase Crashlytics logging statement in MainViewModel currency collection flow
  • FirebaseCrashlytics import from MainViewModel

📊 Statistics

  • Additions: 33 lines
  • Deletions: 14 lines
  • Files Changed: 7
  • Commits: 3

🔗 Related Issues

  • Fixes #
  • Related to #

🧪 Tests Status

  • Tests ran successfully locally?
  • Added more tests? How many?
  • Code coverage percentage of the codebase: __%

📸 Screenshots/Videos

Before After
Add screenshot Add screenshot

🎯 Reviewers

@kcw-grunt, @josikie


Draft Status: This PR is currently in draft mode and ready for review feedback.

@kcw-grunt
kcw-grunt requested a review from amobileagent-gs June 6, 2026 18:30
@kcw-grunt kcw-grunt self-assigned this Jun 6, 2026
@gruntsoftware gruntsoftware deleted a comment from github-actions Bot Jun 6, 2026
@kcw-grunt
kcw-grunt merged commit 89a8974 into develop Jun 6, 2026
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant