Refactored the analytics#226
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📱 Description
This PR refactors the analytics implementation by consolidating event tracking, disabling main activity open events, and adjusting sync analytics thresholds. Firebase analytics collection is now controlled via build variant-specific resource values instead of hardcoded logic. The unlock event constant is simplified to be method-agnostic.
Platform
🎯 Type of Change
Modifications
firebase_analytics_collection_enabledresource values (disabled for debug, enabled for release)._BW_MAIN_OPENconstant; renamed_20200217_DUWBto_20200217_DUfor method-agnostic unlock event tracking.totalDuration == 0LtototalDuration <= 8000Lto filter out short syncs._BW_MAIN_OPENevent logging fromonCreate(); updated unlock event constant reference from_20200217_DUWBto_20200217_DU._20200217_DUWBto_20200217_DU._BW_MAIN_OPENfrom test validation lists; updated constant references from_20200217_DUWBto_20200217_DUin both test methods.Removals
_BW_MAIN_OPENconstant and its logging call fromBrainwalletActivity.onCreate()— main activity open events are no longer tracked.📊 Statistics
🎯 Reviewers
@kcw-grunt, @josikie