Fixxed the layout of the LTC fiat picker#225
Merged
Merged
Conversation
Connected the selection to the picker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📱 Description
This PR fixes the layout of the LTC fiat picker by reorganizing the display of fiat currency information and improving text sizing logic. The fiat amount and timestamp are now displayed above the wheel picker instead of below it, with adjusted initial font sizes (26.sp for fiat, 13.sp for timestamp) and improved overflow handling. The currency formatting logic has been refactored to use
CurrencyDataGetterfor consistent currency display across the app.Platform
🎯 Type of Change
📋 Changes
New Components Added
CurrencyDataGetterdependency toLTCPickerBentoViewModelfor consistent currency formattingModifications
LTCPickerBentoScreen.kt:
TextAlign,delay)Textcomposables from below to above theVerticalWheelPickerresizedFiatFontSizefrom 16.sp to 26.spresizedCurrencyNameFontSizestate variable (no longer needed)resizedAsOfTimestampFontSizefrom 12.sp to 13.spLaunchedEffectlogic to useselectedIndexinstead ofUnittrigger with delaySpacerweight from 0.5f to 1f for better spacing distributionLTCPickerBentoViewModel.kt:
CurrencyDataGetteras constructor dependencyonFiatRateSelected()to useCurrencyDataGetter.getFormattedCurrencyString()instead of simple string formattingBigDecimalrounding logic usingBWConstants.ROUNDING_MODECurrencyDataGetterandBigDecimalLTCPickerBentoViewModelTests.kt:
CurrencyDataGetterLTCPickerBentoViewModelinstantiation to include newcurrencyDataGetterparameterapp/build.gradle.kts:
versionCodefrom 202506327 to 202506328androidx.benchmark:benchmark-traceprocessor:1.4.1gradle/libs.versions.toml:
benchmark-traceprocessor = "1.4.1"androidx-benchmark-traceprocessorRemovals
Textcomposable that displayedstate.selectedCurrency.namestringResource()call; now displays rawstate.formattedTimeStampTextAlign.Startfrom timestamp text styling (uses default)📊 Statistics
🎯 Reviewers
@kcw-grunt, @josikie