Feat/bitrefill in topsecret#221
Merged
Merged
Conversation
Added creatives Added telephony
Added animations Added some tests
removed some stale
Collaborator
Author
|
got the tiny fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📱 Description
This PR integrates Bitrefill gift card functionality into the Brainwallet app's "TopSecret" section. It adds a new Shop Bento section with gift card purchasing capabilities, including support for major retailers (Amazon, Visa, JustEat) and the Bitrefill service. The feature includes navigation routing, state management via MVI architecture, and comprehensive localization across 20+ languages.
Platform
🎯 Type of Change
📋 Changes
New Components Added
Modifications
Removals
📊 Statistics
🔗 Related Issues
🧪 Tests Status
🎯 Reviewers
@kcw-grunt, @josikie
Draft Status: This PR is currently in draft mode and ready for review feedback.
Please verify:
BWConstants.ktWebModalScreen.ktfor proper URL validation and SSL handlingShopBentoViewModelTest.ktfor edge cases (errors, loading states)