Skip to content

CI sandbox (red run): upsert regression tests alone on the unchanged base (spiceai/spiceai#14643) - #2

Draft
grokspice wants to merge 1 commit into
spiceai-55from
fix/duckdb-upsert-keep-last-tests-only
Draft

grokspice wants to merge 1 commit into
spiceai-55from
fix/duckdb-upsert-keep-last-tests-only

Conversation

@grokspice

Copy link
Copy Markdown
Owner

CI sandbox on grokspice's fork, not for merging. This branch applies the final regression tests of #1's branch to the unchanged spiceai-55 base, so the Tests job records them failing before the fix. The real PR goes to spiceai/datafusion-table-providers.

@grokspice

Copy link
Copy Markdown
Owner Author

Converted to draft — this sandbox has produced the evidence it was opened for.

It is the red half of the pair for the upsert fix under review in spiceai#89. Run 37894009849, Tests job, on the regression tests alone against the unchanged spiceai-55 base:

test result: FAILED. 483 passed; 9 failed; 2 ignored; 0 measured; 0 filtered out; finished in 67.78s

All nine failures are the new cases, each showing the last copy of a repeated key being lost:

duckdb::write::test::upsert_overwrite_keeps_the_last_copy_of_a_key_repeated_across_batches
  left: (8192, Some("first"))   right: (8192, Some("last"))
duckdb::write::test::upsert_keeps_the_last_copy_of_a_key_repeated_within_a_batch
  left: (3, Some("first"))      right: (3, Some("last"))
duckdb::write::test::upsert_overwrite_keeps_the_last_of_many_copies_under_a_parallel_scan
  left: (51, Some("copy 5"))    right: (51, Some("copy 49"))

The green half is #1 at head ecf886a0, run 37917555233: Tests → ok. 519 passed; 0 failed; 2 ignored.

Draft rather than closed so the links from #89 keep resolving to a live PR. Not for merging.

@grokspice

Copy link
Copy Markdown
Owner Author

This sandbox is obsolete: the fix it gathered evidence for, spiceai#89, merged on 2026-10-18 as 87c2cba. Nothing here is meant to merge, and it still counts as one of grokspice's open code PRs. A person can close it; bots don't close PRs to make room under the cap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant