Adds the option to submit your own script - #5
Open
ribalba wants to merge 1 commit into
Open
Conversation
ArneTR
reviewed
Aug 12, 2026
ArneTR
left a comment
ArneTR
left a comment
Member
There was a problem hiding this comment.
The integration looks reasonable. Have to see it live to judge CSS/Style quirks if present.
Please have a look at my questions.
| } | ||
|
|
||
| // Custom Playwright paths are not listed under the recent runs, so the job id is the only handle the user has | ||
| if (script !== '' && job_id != null) { |
Member
There was a problem hiding this comment.
Why can we not change the filter query that shows the runs on the frontpage to include?
Does the script-details page provide that much more value that the code duplication scripts-details.js is justified?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relies on two other PRs:
https://github.com/green-coding-solutions/gateway.green-coding.io/pull/1
green-coding-solutions/green-metrics-tool#1818
The idea is that someone can also submit a script through the webnrg interface.