fix(YfmHtmlBlock): preserve nested html block serialization#1162
Merged
Conversation
Reviewer's GuideAdjusts Yfm HTML block Markdown serialization to be line-based so nested blockquotes/lists and trailing blank lines are preserved, and adds regression tests around these cases. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The newline handling in
toMd(stripping withreplace(/\n$/, '')and then checkingsrcdoc.endsWith('\n')) is non-obvious; consider extracting this into a small helper or adding an inline comment to clarify which trailing newlines are treated as structural vs content.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The newline handling in `toMd` (stripping with `replace(/\n$/, '')` and then checking `srcdoc.endsWith('\n')`) is non-obvious; consider extracting this into a small helper or adding an inline comment to clarify which trailing newlines are treated as structural vs content.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
f447993 to
a25819f
Compare
makhnatkin
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
pnpm --filter @gravity-ui/markdown-editor test -- src/extensions/additional/YfmHtmlBlock/YfmHtmlBlock.test.tspnpm exec eslint packages/editor/src/extensions/additional/YfmHtmlBlock/YfmHtmlBlock.test.ts packages/editor/src/extensions/additional/YfmHtmlBlock/YfmHtmlBlockSpecs/index.tsxgit diff --checkNotes
Summary by Sourcery
Preserve correct markdown serialization of YFM HTML blocks, including nested usage and trailing blank lines.
Bug Fixes:
Tests: