Repository navigation
Replace effect-driven state updates in plugins - #4745
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: f5f2ab9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency update exposed eight
react/set-state-in-effectviolations in collections and query builder. Those effects synchronize local state after rendering the previous editor/store snapshot, causing another render of the tree. This removes all eight suppressions and follows React's guidance on adjusting state.The save form mounts with a fresh identity for each save request, including repeated requests with the same operation name. Query-builder document, target, and expansion changes are reconciled before children commit. It keeps the last valid document during incomplete edits, ignores the editor's echo of builder writes, and preserves manual collapse until another cursor event.
Effects remain for imperative cursor restoration, scrolling, and highlight expiration. A deleted-fragment cursor reset belongs to its originating editor, so replacing the editor can't replay it against a different tab.