fix: allow resolve_type to return a type name string for Interface and Union#1605
Open
SAY-5 wants to merge 1 commit into
Open
fix: allow resolve_type to return a type name string for Interface and Union#1605SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…d Union Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1555.
TypeMap.resolve_typesilently ignored string return values from user-definedresolve_typemethods onInterfaceandUniontypes, causing graphql-core to report that the abstract type could not resolve to an object type. Adding anisinstance(type_, str)check passes the string directly to graphql-core, which already accepts type name strings.