Repository navigation
fix: announce an agreement's end once its transaction is known - #740
Merged
MoonBoi9001 merged 2 commits intoOct 9, 2026
Conversation
Dipper can mark an agreement ended before the chain listener records the transaction that ended it, and the terminated event then went out without it. The event now waits for that transaction, for up to an hour, after which it goes out without one as before.
MoonBoi9001
added this pull request to stack #741
October 9, 2026 17:57
MoonBoi9001
marked this pull request as ready for review
October 9, 2026 17:57
MoonBoi9001
removed this pull request from stack #741
October 9, 2026 17:58
MoonBoi9001
added this pull request to stack #742
October 9, 2026 17:58
MoonBoi9001
removed this pull request from stack #742
October 9, 2026 17:58
MoonBoi9001
added this pull request to stack #743
October 9, 2026 17:58
The listener backfilled the accept and ending transaction of agreements dipper had cancelled, but skipped ones it had ended as abandoned, so their terminated event waited an hour for a transaction that never arrived. Abandoned agreements now get the same backfill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An ended agreement's terminated event now waits until the transaction that ended it is recorded, for up to an hour, before going out. Dipper can mark an agreement ended before the chain listener records that transaction, and the event used to go out without it.