Updates to ascii.py and README.md so that we use the same PGraph to produce planar embedding and the mapping of the PGraph nodes to their original labels. - #75
Open
wbkboyer wants to merge 2 commits into
Conversation
…` to produce planar embedding and the mapping of the `PGraph` `nodes` to their original labels.
john-boyer-phd
requested changes
Aug 26, 2026
john-boyer-phd
left a comment
Member
There was a problem hiding this comment.
Now that #70 is in (great work), please update with latest from main and resolve merge conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #72
Type of change
Please check only relevant options:
Changes
Added
Updated
examples/classic/ascii.py- now create a singlePGraphinstance from theedgelist(amapping()ofnodesto their original labels.README.md- updated IDLE example to use the same technique asascii.py. Also fixed formatting of license, since using non-breaking spaces is the cleanest way to indent paragraph contents (otherwise, you'd have to wrap each line in a<p style="indented">Contents</p>).gitignore- somehow my local git started to pick up my virtual environment, so now any virtual environment prepended with.and ending inenvshould be ignored.Removed
Testing
Visually inspected that multiple runs of ascii.py show that (a, b) is not included in the resulting rendition
Details