Update to 26.3 - #168
Open
granny wants to merge 10 commits into
Open
Update to 26.3#168granny wants to merge 10 commits into
granny wants to merge 10 commits into
Conversation
|
|
|
Hello |
@granny From some testing, this PR jar is erroring without some more changes needed from BlueMap's upstream BlockStateDeserializer.java, notably: public BlockState read(NBTReader reader) throws IOException {
+ if (reader.peek() == TagType.STRING)
+ return new BlockState(Key.parse(reader.nextString()));
...
- case "Name" -> id = reader.nextString();
- case "Properties" -> {
+ case "id", "Name", "" -> id = reader.nextString();
+ case "properties", "Properties" -> {something minimal like this is enough to get Pl3xMap 26.3 working: + import de.bluecolored.bluenbt.TagType;
...
public BlockState read(NBTReader reader) throws IOException {
+ if (reader.peek() == TagType.STRING) {
+ return new BlockState(Pl3xMap.api().getBlockRegistry().get(reader.nextString()));
...
- case "Name" -> id = reader.nextString();
- case "Properties" -> {
+ case "id", "Name", "" -> id = reader.nextString();
+ case "properties", "Properties" -> {
}though you may ofc wish to absorb some other changes BlueMap also made for default blockstates in BlueMap-Minecraft/BlueMap@76ba188 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently compiles. Haven't fully tested to see if it works properly. Some features may or may not throw errors, run at your own risk.
Download the pl3xmap jar for this pull request: pl3xmap-168.zip