Skip to content

track leanVM main, add gossip arrival metrics - #123

Merged
ArtiomTr merged 3 commits into
grandinetech:devnet-5-leanvm-mainfrom
bomanaps:feat/leanvm-track-main
Aug 21, 2026
Merged

track leanVM main, add gossip arrival metrics#123
ArtiomTr merged 3 commits into
grandinetech:devnet-5-leanvm-mainfrom
bomanaps:feat/leanvm-track-main

Conversation

@bomanaps

@bomanaps bomanaps commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

We have moved our signature stack onto leanVM main (a5909d18) the new internalized XMSS with 32-byte keys, postcard secret keys, and a prover permit so we never prove concurrently genesis keys need regenerating, so this shouldn't merge into devnet-5 yet. We also added the six new gossip arrival metrics from leanMetrics #40 this should land on its own devnet-* branch e.g. devnet-5-leanvm-main so CI publishes it under a separate image tag and the devnet-5 tag keeps serving the live devnet.

@bomanaps

Copy link
Copy Markdown
Contributor Author

Hello @ArtiomTr please can I get a review on this?

@ArtiomTr

ArtiomTr commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

so this shouldn't merge into devnet-5 yet

So no merge then?

We also added the six new gossip arrival metrics from leanMetrics #40 this should land on its own devnet-* branch e.g. devnet-5-leanvm-main

devnet-5-leanvm-main branch name doesn't make any sense. We can just start devnet-6 branch, as probably those changes should appear in the next version?

@bomanaps

Copy link
Copy Markdown
Contributor Author

so this shouldn't merge into devnet-5 yet

So no merge then?

We also added the six new gossip arrival metrics from leanMetrics #40 this should land on its own devnet-* branch e.g. devnet-5-leanvm-main

devnet-5-leanvm-main branch name doesn't make any sense. We can just start devnet-6 branch, as probably those changes should appear in the next version?

I don't think this belongs on devnet-6 since it's just tracking leanVM main, not the next version's features what if we create a plain leanvm-main branch and add it to the release.yaml triggers? that way CI publishes sifrai/lean:leanvm-main and devnet-5 stays as it is, the plan is to merge this into devnet-5 eventually, but I want to test it with the other clients on a bigger devnet first and compare performance against the current build.

Comment thread lean_client/Cargo.toml Outdated
Comment thread lean_client/xmss/src/aggregated_signature.rs Outdated
Comment thread lean_client/xmss/src/aggregated_signature.rs Outdated
Comment thread lean_client/xmss/src/aggregated_signature.rs Outdated
Comment thread lean_client/xmss/src/aggregated_signature.rs Outdated
@ArtiomTr

Copy link
Copy Markdown
Collaborator

I don't think this belongs on devnet-6 since it's just tracking leanVM main

It is not "just" leanVM update - you're changing signatures, keys - it is essentially large change.

but I want to test it with the other clients on a bigger devnet first

Which devnet? Devnet5?

what if we create a plain leanvm-main branch

I don't see a purpose. If you need a test branch, for doing experiments, then why not building under your own docker image?

@bomanaps

Copy link
Copy Markdown
Contributor Author

I don't think this belongs on devnet-6 since it's just tracking leanVM main

It is not "just" leanVM update - you're changing signatures, keys - it is essentially large change.

but I want to test it with the other clients on a bigger devnet first

Which devnet? Devnet5?

what if we create a plain leanvm-main branch

I don't see a purpose. If you need a test branch, for doing experiments, then why not building under your own docker image?

Before I go the own-image route, do you mind if I share an image I build with the other client teams for interop runs? I remember you weren't in favor when I wanted to build an image and hand it to Katya for a devnet, so I would rather ask first and for context, the other clients already ship two tags, their devnet-5 image and a new leanVM one, and that's what I want to test against, this also can not be validated on my local devnet alone ethlambda is already running 64+ validators on the new leanVM, and I can't run more than 5 nodes locally, so I need to join a proper multi-client devnet to get meaningful numbers.
The reason behind all of this is the finalization issues on the devnet Emile updated leanVM and pointed everyone to this commit to check if it stabilizes things, every client hit the same wall here, no amount of client-side optimization was enough, because the problem was never how optimized any of our code is, it's how much of the slot time the type 2 SNARK proof eats up.

@bomanaps
bomanaps requested a review from ArtiomTr August 15, 2026 01:29
@ArtiomTr
ArtiomTr changed the base branch from devnet-5 to devnet-5-leanvm-main August 21, 2026 07:18
@ArtiomTr
ArtiomTr merged commit 87ca717 into grandinetech:devnet-5-leanvm-main Aug 21, 2026
2 of 3 checks passed
@ArtiomTr

Copy link
Copy Markdown
Collaborator

sorry, took a bit too long to review, merged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants