fix lean-spec-tests-state-transition hive suite - #122
Merged
Conversation
ArtiomTr
reviewed
Aug 10, 2026
ArtiomTr
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but:
- Please fix merge conflicts
- Squash your commits
- Provide readable PR title + description. We don't use
chore:/feat:/etc. prefixes, so you can just use plain title for that.
lean-spec-tests-state-transition suitelean-spec-tests-state-transition hive suite
Author
|
@ArtiomTr ready for review again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the state-transition spec-test suite to green against the devnet-5 fixtures.
Why it was failing
expect_exception→rejection_reason, and some fixtures now omitpost.slot. Our deserializer still expected the old names and a mandatoryslot, so those cases failed to parse.assert!on empty indices, out-of-boundshistorical_block_hashes.get()) or failed to reject inputs the spec expects to be rejected.How it's fixed
TestCase/PostStateto the new field names and madepost.slotoptional; the runner now only checks the slot when a fixture provides it.ensure!/skip logic: reject proposer scheduling on an empty validator set, reject empty aggregation bits, and skip attestations whose source/target/head slot is past the chain view.test_driverto build and run a header throughprocess_block_headerso the invariant actually fires and surfaces assucceeded: false.produce_block/build_blocksignatures.