Conversation
…tput ScratchBuilder.Labels() returns labels in Go map iteration order (random), but relabel.Process requires sorted input. Without builder.Sort(), relabel rules match non-deterministically and ~40-50% of entries reach Loki with renamed labels missing. Adds builder.Sort() plus a 1000-iteration regression test that fails without the fix.
A multi-record S3 source (e.g. CloudTrail) whose total size is a clean multiple of batchSize leaves an empty final batch. Sending an empty PushRequest makes Loki return a non-retryable 422, sending the whole SQS message to the DLQ. Guards sendToPromtail to skip zero-entry batches. Adds a behavioral test asserting no HTTP request is issued for an empty batch (fails if the guard is removed).
fork-release.yml builds the linux/amd64 bootstrap binary, packages a Lambda-ready zip + sha256, and publishes a GitHub release on v*-sortfix.* tags. Upstream release.yml is switched to workflow_dispatch-only because it pushes to grafanalabs S3 buckets we can't access and would otherwise fire on our v* tags.
Add an S3 sink (pkg/s3_sink.go) that, when SIEM_S3_BUCKET is set, writes each batch's raw log lines (gzipped, time-partitioned) to a central SIEM bucket IN ADDITION to the Loki push. Implemented via a multiSink wrapping the existing promtailClient: Loki stays the primary/authoritative sink (governs retry/DLQ), the S3 sink is best-effort so a SIEM-side failure never blocks Loki delivery. Opt-in: no SIEM_S3_BUCKET = unchanged Loki-only behavior. Uses ambient IRSA credentials. No new dependencies (aws-sdk-go-v2 config+s3 already vendored).
Signed commits report6 of 6 commits between
This repository requires all commits to be signed. See GitHub docs on commit signature verification. |
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.