Skip to content

fix: make player fullscreen mode discoverable#1256

Open
Santirv17 wants to merge 3 commits into
mainfrom
1253-modify-player-fullscreen-mode
Open

fix: make player fullscreen mode discoverable#1256
Santirv17 wants to merge 3 commits into
mainfrom
1253-modify-player-fullscreen-mode

Conversation

@Santirv17

Copy link
Copy Markdown
Contributor

The player fullscreen layout was only accessible through ?fullscreen=true, making it difficult for users to discover. This PR exposes the fullscreen control in the normal desktop player and changes to the native Fullscreen API for handling.

  • Shows the fullscreen button in the normal desktop player view
  • Updates the fullscreen search parameter while preserving other player search parameters
  • Returns to the normal player layout when fullscreen is closed through the button, Esc, or F11
  • Removes the unused react-fullscreen-crossbrowser dependency and redundant fullscreen context state
  • Adds Cypress test for entering, exiting, external fullscreen changes, search parameter handling, and direct fullscreen URLs.
  • Updates shortcut and auto-login search-parameter tests, affected by removed dependency, to use shuffle instead of the browser-dependent fullscreen parameter

close #1253
close #1218

@Santirv17 Santirv17 requested a review from spaenleh July 14, 2026 15:40
@Santirv17 Santirv17 self-assigned this Jul 14, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify player fullscreen mode logic Remove dependency react-fullscreen-crossbrowser as it is not needed anymore

1 participant