Skip to content

Handle setImmediates command in encoder open-state tests#4673

Merged
kainino0x merged 1 commit into
gpuweb:mainfrom
shaoboyan091:handle-setimmediates-encoder-open-state
Jun 24, 2026
Merged

Handle setImmediates command in encoder open-state tests#4673
kainino0x merged 1 commit into
gpuweb:mainfrom
shaoboyan091:handle-setimmediates-encoder-open-state

Conversation

@shaoboyan091

@shaoboyan091 shaoboyan091 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

The render pass, render bundle, and compute pass command switches listed setImmediates as a parameter but had no matching case. Once an implementation exposes setImmediates, the feature-presence guard no longer skips and the command falls through to unreachable().

Add a setImmediates case to each switch that issues a minimal valid call, keeping the existing feature-presence guards so the cases still skip when the feature is unavailable.

Issue: #4669


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

The render pass, render bundle, and compute pass command switches listed
setImmediates as a parameter but had no matching case. Once an implementation
exposes setImmediates, the feature-presence guard no longer skips and the
command falls through to unreachable().

Add a setImmediates case to each switch that issues a minimal valid call,
keeping the existing feature-presence guards so the cases still skip when the
feature is unavailable.

Issue gpuweb#4669
@shaoboyan091 shaoboyan091 requested a review from kainino0x June 23, 2026 08:44
@github-actions

Copy link
Copy Markdown

Results for build job (at e948437):

 Test case/subcase counts did not change.

@kainino0x kainino0x merged commit b128863 into gpuweb:main Jun 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants