buffer_view CTS#4652
Open
alan-baker wants to merge 2 commits into
Open
Conversation
* Validation of buffer type and related builtin functions
* Tests for * bufferLength * bufferView * bufferArrayView
|
Results for build job (at dd3cfe0): +webgpu:api,validation,dispatch:shader_required_buffer_size:* - 19 cases, 76 subcases (~4/case)
+webgpu:shader,execution,expression,call,builtin,bufferArrayView:array_length:* - 78 cases, 832 subcases (~11/case)
+webgpu:shader,execution,expression,call,builtin,bufferArrayView:array_length,functions:* - 78 cases, 1170 subcases (~15/case)
+webgpu:shader,execution,expression,call,builtin,bufferArrayView:read_layout:* - 35 cases, 604 subcases (~17/case)
+webgpu:shader,execution,expression,call,builtin,bufferArrayView:write_layout:* - 35 cases, 604 subcases (~17/case)
+webgpu:shader,execution,expression,call,builtin,bufferArrayView:read:* - 4 cases, 744 subcases (~186/case)
+webgpu:shader,execution,expression,call,builtin,bufferArrayView:write:* - 4 cases, 1224 subcases (~306/case)
+webgpu:shader,execution,expression,call,builtin,bufferLength:sized_buffer:* - 5 cases, 120 subcases (~24/case)
+webgpu:shader,execution,expression,call,builtin,bufferLength:unsized_buffer:* - 5 cases, 80 subcases (~16/case)
+webgpu:shader,execution,expression,call,builtin,bufferLength:max_size_buffer:* - 6 cases, 6 subcases (~1/case)
+webgpu:shader,execution,expression,call,builtin,bufferView:array_length:* - 78 cases, 832 subcases (~11/case)
+webgpu:shader,execution,expression,call,builtin,bufferView:array_length,functions:* - 78 cases, 1542 subcases (~20/case)
+webgpu:shader,execution,expression,call,builtin,bufferView:read_layout:* - 35 cases, 604 subcases (~17/case)
+webgpu:shader,execution,expression,call,builtin,bufferView:write_layout:* - 35 cases, 604 subcases (~17/case)
+webgpu:shader,execution,expression,call,builtin,bufferView:read:* - 4 cases, 856 subcases (~214/case)
+webgpu:shader,execution,expression,call,builtin,bufferView:write:* - 4 cases, 1224 subcases (~306/case)
-webgpu:shader,validation,decl,let:type:* - 21 cases, 21 subcases (~1/case)
-webgpu:shader,validation,decl,let:initializer:* - 10 cases, 10 subcases (~1/case)
[snip - full report in action logs]
-TOTAL: 281361 cases, 2323132 subcases
+TOTAL: 282684 cases, 2338877 subcases |
mwyrzykowski
approved these changes
Jun 23, 2026
dneto0
requested changes
Jun 25, 2026
| }); | ||
|
|
||
| const buffer = t.createBufferTracked({ | ||
| size: t.params.valid ? testcase.size : testcase.size - 4, |
Contributor
There was a problem hiding this comment.
I had to look up why this uses "- 4".
It comes from the fact that the buffer binding size in createBindGroup must be a multiple of 4. That's just a familiarity thing for me.
No request for change.
| binding_type: 'read-only-storage', | ||
| requires: ['buffer_view'], | ||
| }, | ||
| }; |
Contributor
There was a problem hiding this comment.
This needs test cases for:
- offset is an override expression
- with initializer
- with pipeline-time-supplied initializer value
- size parameter is an override expression.
- if so, then use that size.
- otherwise use MinTypeSize. (See my question / comment at https://github.com/gpuweb/gpuweb/pull/6291/changes#r3469837734 )
Contributor
There was a problem hiding this comment.
uh, I think my request is nonsense because the size param has to be a const-expression. (!)
| requires: ['buffer_view'], | ||
| }, | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
Also, the bufferArrayView cases less rich than the bufferView cases.
Interesting ones missing for bufferArrayView
- compute max value across multiple uses in a shader
- multiple uses in the shader, but only pay attention to the ones statically used by the shader in the pipeline
| ): boolean { | ||
| if (size === 0) { | ||
| // bufferView case | ||
| return offset + (type.arrayOffset ?? 0) + type.stride < bufferSize; |
Contributor
There was a problem hiding this comment.
Should this be less-than-or-equal?
Also on line 45.
| } | ||
| } | ||
|
|
||
| export function calculateArrayLength( |
Contributor
There was a problem hiding this comment.
Worth saying this returns the element count. That's a bit less ambiguous
| decls: `@group(0) @binding(0) var<storage> b : buffer;`, | ||
| }, | ||
| buffer_sized: { | ||
| code: `let x = buffer<128> = b;`, |
| code: `let x : ptr<uniform, buffer<64>> = &b;`, | ||
| valid: false, | ||
| decls: `@group(0) @binding(0) var<uniform> b : buffer<128>;`, | ||
| }, |
Contributor
There was a problem hiding this comment.
another case:
- workgroup sized buffer with override size, assign its address to ptr-workgr-sized-buffer but mismatched override identifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffer_view validation and execution CTS tests.
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.