Repository navigation
Add support for Symfony 8 - #100
Merged
Merged
Conversation
The bundle sources are already compatible with Symfony 8, only the constraints, the test suite and the CI matrix needed changes. Symfony 8 requires PHP 8.4 +, which in turn requires PHPUnit 10 + and PHPStan 2. The test suite is made compatible with PHPUnit 7 - 12 at once: * data providers are static and declared with the #[DataProvider] attribute in addition to the @dataProvider annotation, the attribute is a plain comment on PHP 7.x; * withConsecutive() and at() are replaced with willReturnCallback(); * assertMatchesRegularExpression() is final since PHPUnit 10 and can not be used as a BC shim any more. The configuration schemas of PHPUnit 9 and 10 are incompatible, so phpunit-10.xml.dist is added next to phpunit.xml.dist. TestReader can not redeclare the filename and the locales properties: GeoIP2 3.x declares Reader::$locales as a readonly promoted property. This also fixes the already failing "PHP 8.3 + GeoIP2 ~3.0" build. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* PHPStan is run from vendor/bin instead of a global install: the configs include the extension of the locally installed phpstan-phpunit, and a globally pinned PHPStan skews from it; * PHPStan 2 proves the Configuration BC layers dead since Symfony 4.2, not only on Symfony 8, so the ignores move from symfony_8.neon to symfony_5.neon; * symfony_7.neon is dropped: checkGenericClassInNonGenericObjectType is removed in PHPStan 2, which does not report the missing generic types of the Symfony 7.3 + node definitions at all; * Composer blocks the install of the out of support Symfony versions that the matrix tests on purpose; * no_unneeded_control_parentheses violations reported by PHP CS Fixer. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The service does not serve ocular.phar any more, it answers 403 Forbidden, which fails every PHP 7.2 build after the tests already passed. Coverage keeps being uploaded to Coveralls. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The coverage upload to Scrutinizer is dropped, the service is not used any more. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #98
The bundle sources are already compatible with Symfony 8, only the constraints, the test suite and the CI matrix needed changes.
Symfony 8 requires PHP 8.4 +, which in turn requires PHPUnit 10 + and PHPStan 2. The test suite is made compatible with PHPUnit 7 - 12 at once:
The configuration schemas of PHPUnit 9 and 10 are incompatible, so phpunit-10.xml.dist is added next to phpunit.xml.dist.
TestReader can not redeclare the filename and the locales properties: GeoIP2 3.x declares Reader::$locales as a readonly promoted property. This also fixes the already failing "PHP 8.3 + GeoIP2 ~3.0" build.