fix(go): pass context to functions - #14
Open
syndbg wants to merge 1 commit into
Open
Conversation
Enables cancellation, timeouts and follow industry best practices for Go. ``` Do not store Contexts inside a struct type; instead, pass a Context explicitly to each function that needs it. This is discussed further in https://go.dev/blog/context-and-structs. The Context should be the first parameter, typically named ctx: ``` ref: https://pkg.go.dev/context
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors Go cache helper functions to accept a context.Context parameter from the caller instead of creating a new background context internally, allowing proper context propagation.
Changes:
- Updated
getFromCacheandsaveToCachesignatures in both starter and solution to acceptctx context.Context. - Updated call sites in
mainto pass the existingctx. - Removed internal
context.Background()creation in solution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| workshop/session-2/go/starter/main.go | Add ctx parameter to cache function signatures and pass it from main. |
| workshop/session-2/go/solution/main.go | Same signature update; remove internal context.Background() calls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables cancellation, timeouts and follow industry best practices for Go.
ref: https://pkg.go.dev/context