fix(retained): preserve Claude session after interrupted turns - #21
Merged
Merged
Conversation
Contributor
Author
|
@greptileai Please review this SDK session-retention fix. |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The retained runtime only stored the provider session ID from a successful
TurnResult. Claude announces the session earlier throughSessionStarted; when a running turn is interrupted, its completion isCancelled, so the runtime discarded the announced ID. The next follow-up started a new Claude session without history.Fix
Capture the latest session announced during each invocation and retain it after success, failure, or cancellation. Prefer the completed turn's session ID when one exists.
Evidence
The new
interrupted_turn_keeps_the_session_the_provider_already_startedregression test failed before the fix with[None, None]and passes with the follow-up receivingsession-interrupted.cargo fmt --check,cargo test --all-features, and clippy with warnings denied passed locally.Fleet integration will pin the corresponding commit on
feat/provider-process-retentiononce this review is clear.