fix(windows): preserve provider launch environment and test native shims - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows provider launches need system/profile variables and npm shim resolution while preserving explicit argv and excluding unrelated credentials. This change preserves a case-insensitive environment allowlist, resolves bare Windows launchers against the effective PATH, and suppresses launch/cleanup console windows.
Native fixtures exercise JSON, Unicode, spaces, shell metacharacters, environment-expansion syntax, exact stdin, explicit environment overlays, nonzero exits and cancellation. Windows tests run Claude/Codex/OpenCode
.cmdfixtures through the same launcher and reject CR/LF arguments before execution. Rust 1.88 includes the batch-escaping fix introduced in 1.77.2; noraw_argis used.Also forwards Fleet developer instructions to Codex thread start/resume, probes OpenCode through
/global/health, and only treats deliberate attached-server termination as successful after a terminal protocol event. Verification exposed an early-exit race in extension commands: stdin and stdout now run concurrently under the existing deadline so a rejecting child's stderr is preserved instead of being replaced by BrokenPipe.Validation:
Authenticated provider journeys, Windows OS services and Job Object ownership are outside these fixtures. SSH password authentication remains Unix-only. The cancellation fixture proves immediate-child termination, not a full Windows descendant-process lifecycle.