Repository navigation
Conversation
…INS_DIR Rename the product from Slopsmith to feedBack in README prose, and document that core reads FEEDBACK_PLUGINS_DIR first while still accepting the SLOPSMITH_PLUGINS_DIR name the dev overlay sets (feedBack plugins/__init__.py). Real identifiers are kept as they are: window.slopsmith (still aliased by core app.js), the Makefile's SLOPSMITH_DIR / SLOPSMITH_PORT, docker-compose.slopsmith.yml, and historical slopsmith#NNN refs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: odntht <odntht@gmail.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The README still called the host "Slopsmith" all the way through (title, install comment, host APIs, desktop sections, Requirements, Develop locally). The dev section also presented
SLOPSMITH_PLUGINS_DIRas the only way to mount user plugins.What changed
slopsmith-desktop/src/audio/MlNoteDetector.*is nowfeedBack-desktop/src/audio/MlNoteDetector.*. That path exists on feedBack-desktopmain.FEEDBACK_PLUGINS_DIRfirst and still acceptsSLOPSMITH_PLUGINS_DIR, which is the name the overlay sets. Coreplugins/__init__.py:1170hasos.environ.get("FEEDBACK_PLUGINS_DIR") or os.environ.get("SLOPSMITH_PLUGINS_DIR").window.slopsmith: the plugin emits on it (screen.jswindow.slopsmith.emit), and core still aliases it (static/app.js:336window.slopsmith = window.feedBack). The README now says it's the legacy alias.SLOPSMITH_DIRandSLOPSMITH_PORT: Makefile and.env.examplevariables.docker-compose.slopsmith.ymlfile name.slopsmith#254,slopsmith#818andslopsmith@b65a08c.Verification
grepthat remains for "slopsmith" inREADME.mdonly hits the identifiers and historical refs listed above.got-feedBack/feedBackmain.Docs only. Overlap notes:
screen.jsthat fix(diagnostic): launch the renamed feedBack-diagnostic pack #83 already covers, so this PR doesn't reference it.🤖 Generated with Claude Code