[mattromano]

What

Closes #81

On the desktop engine-verifier path, checkMisses() returns before its section scan, so currentSection never advanced and every updateSectionStat() call did nothing. sectionStats and notedetect:session.sections were always empty on desktop.

• Moved the section scan into _ndTrackSection(t), using a small _ndSectionNameAt(t) lookup. checkMisses() still calls it at the same point on the browser path. On the engine path it now calls it with the same corrected playhead before returning, so the playhead's section row still opens with 0/0.
• updateSectionStat(type, noteTime) now bins a judgment by the section its note is in (judgment.noteTime), and falls back to the playhead's currentSection when the note time is unknown. Engine verdicts land after a note's window closes, often once the playhead is in the next section. Without this, a section's last notes would be credited to the following one. On the browser path, the judgments that carry a note time now bin by the note too, which is the same or more accurate.
• No change to the sectionStats / notedetect:session.sections shape.

No version bump: there's no stylesheet change. #72, #74, #76 and #78 all bump to 1.33.0, so the maintainer can re-bump after those land if they want one. This branch merges cleanly with all four and with the technique-flags fix (checked with git merge-tree).

Note: #78 adds a top-level _ndSectionAt(sections, t) for the section field on hit/miss payloads, with the same semantics. Once both land, the two lookups can be merged into one.

Tests

• New test/engine_section_stats.test.js (2 tests). It uses the engine-verifier harness: a stubbed feedBackDesktop.audio with queued verdicts and a chart with Intro/Verse sections.
  • verdicts bin into [{Intro 1/1}, {Verse 2/0}]. Before the fix this was [].
  • a late verdict for the Intro's last note, delivered once the tracker has opened the Verse, still counts toward the Intro
  • Both tests fail on main. With the tracker change but without note-time binning, both still fail.
• npm test: 355/355 pass. node --check screen.js is OK, and feedBack-plugin-spec/tools/validate.py reports ok.

Checklist

• Tests added/updated for new behaviour
• Version bumped in all three places. Intentionally skipped: there's no CSS change, and it avoids colliding with the 1.33.0 bumps in fix(tuning): score against the effective (chart-transform) tuning #72/fix(capo): read capo charts' fretted notes from the nut #74/fix(chord): stop ringing chords in fast runs scoring as EARLY misses #76/feat(events): richer notedetect:hit/miss payloads for stats plugins #78.
• Commits are DCO signed off (git commit -s)

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 15f572b1-301a-4233-ac1a-0035078f6a51

---

📥 Commits

Reviewing files that changed from the base of the PR and between 412433d and d679215.

---

📒 Files selected for processing (2)

• screen.js
• test/engine_section_stats.test.js

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[mattromano]

Consolidated into #84 (commits kept, rebased onto main, plus the review fixes).