Repository navigation
Conversation
The README described what gets imported but not how to use the screen. Add Usage steps taken from screen.html / screen.js / routes.py (drop zone, prefilled title and composer, audio toggle, Build Feedpak, output in <dlc>/musicxml/), note the plugin is bundled in feedBack Desktop, and use the org's feedBack casing. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: odntht <odntht@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
feedBack-desktop/scripts/build-common.shlistsgot-feedback/feedback-plugin-musicxml-import).What changed
New Usage section, written from the code:
plugins-page.js: clicking a pedal opens the plugin's screen)..xml .musicxml .mxl(screen.html#mxi-dropzone)./parse-arrangement(screen.js:100-101).<dlc>/musicxml/<title>_<composer>_mxml.feedpakand indexes it (routes.pybuild websocket:out_dir = Path(dlc) / 'musicxml', theout_namepattern,_meta_db.put).Plus the one-line bundled note and "FeedBack" → "feedBack" in prose (3 places). I didn't touch the license text.
Verification
curl -L https://github.com/got-feedback/feedpak-specreturns 200 (the existing link).screen.html/screen.jsonmain.Docs only.
🤖 Generated with Claude Code