Repository navigation
Conversation
The README said a button appears in the player controls. Since 4.0.0 the plugin is a visualization renderer (plugin.json "type": "visualization", window.feedBackViz_drums), so it is chosen in the viz picker or by Auto mode via matchesArrangement. Only the settings gear is injected, and v3 re-homes it into the Plugin controls popover. Rewrite Usage for that. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: odntht <odntht@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The Installation section said: A "Drums" button will appear in the player controls when you play a song. Click the gear icon next to it... That no longer matches the code:
plugin.jsondeclares"type": "visualization", andscreen.jsregisterswindow.feedBackViz_drums(withslopsmithViz_drumsas an alias). Core's picker (static/js/viz.js) lists it by its name, Drum Highway, in the Visualization & quality popover (#viz-pickerinstatic/v3/index.html).createFactory.matchesArrangementpicks it for songs withhas_drum_taband for arrangements matching/\b(?:drums|percussion|drum\s*kit)\b/i.init→_injectSettingsGear,destroy→_removeSettingsGear). The gear goes into#player-controls, or into the panel bar under splitscreen, and the v3 UI re-homes it into the Plugin controls popover (static/v3/player-chrome.js).What changed
feedBack-desktop/scripts/build-common.sh).Verification
Auto (match arrangement),Classic 2D Highway,Visualization & quality,Plugin controls) was checked against coremain.screen.js.Docs only. I left the clone URL alone because #13 already changes its casing. The new section has no overlap with it.
🤖 Generated with Claude Code