Skip to content

ci: adopt org-wide reusable CI workflow - #16

Merged
OmikronApex merged 1 commit into
mainfrom
chore/unified-ci
Jul 7, 2026
Merged

OmikronApex merged 1 commit into
mainfrom
chore/unified-ci

Conversation

@OmikronApex

@OmikronApex OmikronApex commented Jul 7, 2026 •

Copy link
Copy Markdown
Contributor

Adds the thin caller for the org-wide reusable CI workflow in got-feedback/.github (see got-feedBack/.github#4). The reusable workflow self-detects this repo's test stack (plain-node JS scripts, npm test, and/or pytest) and no-ops green when there is nothing to run — so this repo needs no CI changes when tests are added later.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Added a new automated CI workflow for changes targeting the main branch.
    • The workflow runs on push and pull request events to help catch issues earlier and improve overall build reliability.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Added a new GitHub Actions workflow file .github/workflows/ci.yml that triggers on push and pull_request events targeting the main branch, delegating execution to a reusable workflow hosted in another repository.

Changes

CI Workflow Setup

Layer / File(s) Summary
Add CI workflow
.github/workflows/ci.yml
New workflow triggers on push/pull_request to main and runs a single ci job that calls the reusable workflow got-feedback/.github/.github/workflows/reusable-ci.yml@main.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: ci, github-actions

Suggested reviewers: none

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: switching this repo to the org-wide reusable CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/unified-ci

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)

10-10: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Pin reusable workflow to a tag/SHA instead of @main.

Referencing a mutable branch ref means any future change to got-feedback/.github's main branch silently changes this repo's CI behavior, with no review gate on this side.

🔒 Suggested pinning approach
-    uses: got-feedback/.github/.github/workflows/reusable-ci.yml@main
+    uses: got-feedback/.github/.github/workflows/reusable-ci.yml@v1  # or a pinned commit SHA
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml at line 10, The reusable workflow reference in the
CI workflow is using the mutable `@main` ref, so update the uses entry to point to
a fixed tag or commit SHA instead. Change the workflow reference in the CI
configuration so the reusable workflow from got-feedback/.github is pinned to an
immutable version, keeping the workflow definition stable over time.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/ci.yml:
- Line 10: The reusable workflow reference in the CI workflow is using the
mutable `@main` ref, so update the uses entry to point to a fixed tag or commit
SHA instead. Change the workflow reference in the CI configuration so the
reusable workflow from got-feedback/.github is pinned to an immutable version,
keeping the workflow definition stable over time.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b48bc2fb-d522-4d56-9dbd-59ee1b386cee

📥 Commits

Reviewing files that changed from the base of the PR and between db32570 and 2baf75c.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

@OmikronApex OmikronApex closed this Jul 7, 2026
@OmikronApex OmikronApex reopened this Jul 7, 2026
@OmikronApex
OmikronApex merged commit 80d0013 into main Jul 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant