Repository navigation
Conversation
Add a table of the environment variables server.py reads, with defaults from the code. Add PORT and HOST to the Docker table. Document POST /separate-url and DELETE /cache/{job_id}, which exist in server.py but were missing from the API section. Drop SLOPSMITH_DEMUCS_DEVICE from the list: it is read but never applied.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: odntht <odntht@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The upstream docker pull used byrongamatos/slopsmith-demucs-server. CI publishes ghcr.io/got-feedback/feedback-demucs-server (lowercased repo name), which is also what docker-compose.yml uses. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: odntht <odntht@gmail.com>
odntht
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
SLOPSMITH_DEMUCS_MODEL,SLOPSMITH_DEMUCS_DEVICE,SLOPSMITH_API_KEY).server.pyalso readsSLOPSMITH_DEMUCS_CACHE_MAX_JOBS(server.py:254),MODEL_IDLE_TIMEOUT(:215) andSLOPSMITH_MAX_WHISPERX_ALIGNERS(:543). The Docker table did not listPORT/HOST, whichdocker-entrypoint.sh:105passes toserver.py.SLOPSMITH_DEMUCS_DEVICEis read intoDEMUCS_DEVICE(server.py:80) but never used._devicestarts as""(:320) and only--deviceor GPU detection sets it. So the README's claim that it overrides the CLI default is not true today.POST /separate-url(server.py:487) orDELETE /cache/{job_id}(server.py:1776).What changed
SLOPSMITH_DEMUCS_DEVICEis left out. Use--deviceuntil the variable is wired up.PORTandHOSTrows to the Docker env table.docker pullusedghcr.io/byrongamatos/slopsmith-demucs-server. It now usesghcr.io/got-feedback/feedback-demucs-server:latest. That is the lowercased name CI tags (${REPO_NAME,,}indocker-build.yml), theimage:indocker-compose.yml, and an anonymous manifest fetch for:latestreturns 200.POST /separate-url(JSON body{"url": ...}, samestems/modelquery params, 400 on missing URL or failed download) andDELETE /cache/{job_id}(returns{"ok": true}, 400 on an invalid job ID).Not in this PR
The title, intro link and badge rename is already covered by #12, so this PR leaves those lines alone. This PR does fix the
docker pullline, because #12 changes it toghcr.io/got-feedBack/feedBack-demucs-server:latest. Docker rejects that reference since registry repository names must be lowercase. #12 also renames the variables toFEEDBACK_*. Whichever PR lands second needs the names in the new table adjusted. I can rebase this one if #12 merges first.Verification
Every default was read from
server.py,docker-entrypoint.shand theDockerfileonmain. The new#cache-cleanupanchor matches the existing heading.🤖 Generated with Claude Code