fix(python-sdk): pass CommandFactory (not invoked coroutine) to observables

[akeildev]

Description

GoproObserverDistinctInitial.start() invokes the registration command as a factory:

# domain/gopro_observable.py:24
CommandFactory = Callable[[], Coroutine[Any, Any, GoProResp[Any]]]
# domain/gopro_observable.py:89
initial_response = await self._register_command_factory()

Several call sites pass an already-invoked coroutine instead of a factory, so start() ends up calling a coroutine object:

TypeError: 'coroutine' object is not callable
  File ".../features/access_point_feature.py", line 88, in connect
    if is_successful(response := await self.scan_wifi_networks()):
  File ".../features/access_point_feature.py", line 59, in scan_wifi_networks
    async with GoproObserverDistinctInitial[...](
  File ".../domain/gopro_observable.py", line 64, in __aenter__
    await self.start()
  File ".../domain/gopro_observable.py", line 89, in start
    initial_response = await self._register_command_factory()
TypeError: 'coroutine' object is not callable

This makes AccessPointFeature.connect() fail deterministically, which in turn breaks COHN provisioning (it calls access_point.connect()), and also affects LiveStreamController's status observable.

Affected call sites (passing coro() where a Callable[[], coro] is expected)

• features/access_point_feature.py:61 — register_command=self._gopro.ble_command.scan_wifi_networks()
• features/access_point_feature.py:104 — register_command=command (where command is an invoked coroutine)
• features/streaming/livestream.py:82,85 — register_command / unregister_command

The correct pattern (a lambda: factory) is already used elsewhere, e.g. features/cohn_feature.py:69 and api/builders.py.

Fix

Wrap these in factories:

• scan_wifi_networks() → lambda: ...scan_wifi_networks()
• the wifi-connect command → functools.partial(...)
• livestream register/unregister → lambda: ...

No behavior change beyond deferring coroutine creation to call time, as the type contract intends.

Testing

Verified against a HERO12 Black. Before: gopro.access_point.connect(ssid, pw) raised 'coroutine' object is not callable. After: it completes the WiFi scan and returns a normal Result (e.g. a clean <Failure: Could not find SSID: ...> for a non-existent SSID, and provisioning proceeds for a real one). py_compile passes on both files.

Related

May explain user-reported COHN provisioning / scan_wifi_networks failures discussed in #744.

Checklist

• References an issue / describes the bug above
• No new files requiring copyright headers
• Pre-merge checks (will run on PR)

🤖 Generated with Claude Code
https://claude.ai/code/session_017S8amPPZwqFt7hqdNk3yJh

[githappens]

Independent reproduction on a MAX 2 (firmware H24.02.01.30.00), open_gopro 0.23.0, Python 3.12, macOS.

I hit this while writing a LAN media-sync tool and arrived at the same fix before finding this PR, so this is a second data point on different hardware from the HERO12 in the description.

Impact is broader than "wifi scanning fails": it blocks COHN provisioning outright, since CohnFeature.configure() reaches access_point.connect() → scan_wifi_networks(). On a factory-fresh camera there is no way through gopro-cohn --ssid ... --password ... at all — it fails deterministically, every time:

TypeError: 'coroutine' object is not callable
  File ".../features/access_point_feature.py", line 87, in connect
    if is_successful(response := await self.scan_wifi_networks()):
  File ".../features/access_point_feature.py", line 58, in scan_wifi_networks
    async with GoproObserverDistinctInitial[ResponseStartScanning, NotifStartScanning](
  File ".../domain/gopro_observable.py", line 64, in __aenter__
    await self.start()
  File ".../domain/gopro_observable.py", line 89, in start
    initial_response = await self._register_command_factory()

With the fix applied, provisioning completes normally against an already-saved network:

Scanning for Wifi networks...
Connecting to already provisioned network ...
COHN is connected

and the camera is then reachable over HTTPS with the issued certificate (/gopro/camera/state → 200, full chain validation against the returned root CA, no --insecure).

On completeness — the three call sites here appear to be the full set. Grepping every observable registration in the SDK after applying this patch:

$ grep -rn "register_command=" open_gopro/ --include="*.py" | grep -vE "lambda|partial"
open_gopro/features/access_point_feature.py:107:    register_command=command,

which is the partial bound a few lines above, so it is correct. Everything else already uses a lambda factory (cohn_feature.py:69, api/builders.py).

One small thing that may be worth folding in: CommandFactory is a plain Callable, so passing a coroutine is only caught at await time, deep inside start(), with a traceback that points at the observable rather than the call site that got it wrong. A callable() assertion in GoProObservable.__init__ would surface it immediately and with the right blame.