fix(audio): keep paused playback alive - #2018
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Reviewed the complete fixed range from 03576e6c0bbead9e73736482539dd321f5521206 through 546aeea343b36ee404f7fd87a9e772cf171fe9f9, including the Godot audio lifetime change, backend contract documentation, generated metadata, and regression coverage. The paused-state query is consistent with the existing cleanup logic, and the focused validation passed with go test ./internal/audio and git diff --check; no concrete, actionable findings remain.
songweijun1203
approved these changes
Sep 28, 2026
joeykchen
force-pushed
the
fix/paused-audio-lifetime
branch
from
September 28, 2026 04:31
546aeea to
0a18441
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Godot reports an active paused stream as not playing. Forwarding that value made the Go audio manager discard its playback ID before Resume, and allowed its wait/cleanup paths to treat the sound as finished. Make the engine query include the existing paused state, consistent with the backend's voice-retention rule, and document that lifetime contract on the Go Backend interface.
The second cleanup review keeps this to one backend expression and one contract comment. No Go paused-state mirror or additional helper is introduced. This engine-side fix requires a runtime built with the updated SPX module.
Validation: