refactor: remove unused tilemap decoding state - #2003
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Reviewed the complete fixed diff for the legacy tilemap loader, five-integer tile-record parsing, incomplete-tail handling, source grouping, decorator loading, world-bound calculation, and generated export metadata. I found no concrete, actionable bug introduced by this patch. Verification: go test ./internal/tilemap passes.
songweijun1203
approved these changes
Sep 28, 2026
joeykchen
force-pushed
the
refactor/tilemap-decoding-state
branch
from
September 28, 2026 03:09
24c40c1 to
37e4664
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the old-map conversion that only modified range copies, and stop expanding atlas coordinates that tile placement never reads. Keep all JSON input fields and the five-integer record format. The private expanded record shrinks from 20 to 12 bytes.
A second cleanup removes unused serialization tags and temporary variables and reads only complete records. Placement order, paths, incomplete tails, missing sources, and the existing source sentinel behavior stay unchanged.
Validation: callback-trace and old-format path tests passed before the refactor; all 78 host packages, pure-engine tilemap tests/root compilation, and WebAssembly root compilation passed with Go 1.26.5. Runtime metadata was regenerated twice with identical final diffs.
Integration note: other pending runtime refactors also update the generated
export.types. Regenerate it withmake generate-runtimewhen combining those branches. This change has no source-file overlap with refactor PRs #1975–#2001.Combined validation of all five independent cleanup branches also passed: all host packages, codegen and interpreter submodules, pure/wasm root compilation, and actual Web binding wasm tests. Two full generation runs were identical, with all six external Godot outputs unchanged.