Skip to content

refactor: remove unused tilemap decoding state - #2003

Merged
joeykchen merged 1 commit into
goplus:devfrom
joeykchen:refactor/tilemap-decoding-state
Sep 28, 2026
Merged

joeykchen merged 1 commit into
goplus:devfrom
joeykchen:refactor/tilemap-decoding-state

Conversation

@joeykchen

Copy link
Copy Markdown
Contributor

Remove the old-map conversion that only modified range copies, and stop expanding atlas coordinates that tile placement never reads. Keep all JSON input fields and the five-integer record format. The private expanded record shrinks from 20 to 12 bytes.

A second cleanup removes unused serialization tags and temporary variables and reads only complete records. Placement order, paths, incomplete tails, missing sources, and the existing source sentinel behavior stay unchanged.

Validation: callback-trace and old-format path tests passed before the refactor; all 78 host packages, pure-engine tilemap tests/root compilation, and WebAssembly root compilation passed with Go 1.26.5. Runtime metadata was regenerated twice with identical final diffs.

Integration note: other pending runtime refactors also update the generated export.types. Regenerate it with make generate-runtime when combining those branches. This change has no source-file overlap with refactor PRs #1975–#2001.

Combined validation of all five independent cleanup branches also passed: all host packages, codegen and interpreter submodules, pure/wasm root compilation, and actual Web binding wasm tests. Two full generation runs were identical, with all six external Godot outputs unchanged.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete fixed diff for the legacy tilemap loader, five-integer tile-record parsing, incomplete-tail handling, source grouping, decorator loading, world-bound calculation, and generated export metadata. I found no concrete, actionable bug introduced by this patch. Verification: go test ./internal/tilemap passes.

@joeykchen
joeykchen force-pushed the refactor/tilemap-decoding-state branch from 24c40c1 to 37e4664 Compare September 28, 2026 03:09
@joeykchen
joeykchen merged commit 1bb981e into goplus:dev Sep 28, 2026
5 checks passed
@joeykchen
joeykchen deleted the refactor/tilemap-decoding-state branch September 28, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants