cl: tryToMethod bugfix; conf.TypeSuffix - #882
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
==========================================
+ Coverage 88.04% 88.49% +0.44%
==========================================
Files 22 22
Lines 1857 1860 +3
==========================================
+ Hits 1635 1646 +11
+ Misses 222 214 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Review summary
This PR fixes a type-initialization ordering bug (completing uninitialized typDecls before ctx.compile()), improves diagnostics by attaching source positions to panics (ctx.panicf), removes the dead llgoSupportAliasAsRecv branch in tryToMethod, adds verbose-mode debug wiring (DbgFlagMajorProc, gogen debug), and bumps gogen v1.25.2 → v1.25.3.
Overall the changes are sound. The ctx.compile() reordering correctly matches the stated intent and is performance-neutral (order-independent work queue). The tryToMethod refactor preserves behavior while avoiding double-dereference of pointer aliases. go vet ./cl/ passes. The one blocking item is a nil-pointer dereference in a new error path that masks the real error.
Verified locally: go vet ./cl/ clean; go build ./cl/... type-checks (final link fails only on expected llgo-specific symbols, unrelated to this diff). The DbgFlag* rename has no stale references anywhere in the repo.
Adjacent note (not in this diff): cl/union.go:158 panic for union alignment > 8 is prefixed [WARN] yet is fatal, unlike neighboring branches that degrade gracefully. Worth converting to a logged skip in a follow-up.
No description provided.