Skip to content

cl: tryToMethod bugfix; conf.TypeSuffix - #882

Merged
xushiwei merged 3 commits into
goplus:mainfrom
xushiwei:q
Sep 30, 2026
Merged

xushiwei merged 3 commits into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.49%. Comparing base (ea24b24) to head (39cc473).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
cl/class.go 0.00% 1 Missing ⚠️
cl/func.go 90.90% 1 Missing ⚠️
cl/union.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
+ Coverage   88.04%   88.49%   +0.44%     
==========================================
  Files          22       22              
  Lines        1857     1860       +3     
==========================================
+ Hits         1635     1646      +11     
+ Misses        222      214       -8     
Flag Coverage Δ
llgo-tests 88.49% <89.65%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

This PR fixes a type-initialization ordering bug (completing uninitialized typDecls before ctx.compile()), improves diagnostics by attaching source positions to panics (ctx.panicf), removes the dead llgoSupportAliasAsRecv branch in tryToMethod, adds verbose-mode debug wiring (DbgFlagMajorProc, gogen debug), and bumps gogen v1.25.2 → v1.25.3.

Overall the changes are sound. The ctx.compile() reordering correctly matches the stated intent and is performance-neutral (order-independent work queue). The tryToMethod refactor preserves behavior while avoiding double-dereference of pointer aliases. go vet ./cl/ passes. The one blocking item is a nil-pointer dereference in a new error path that masks the real error.

Verified locally: go vet ./cl/ clean; go build ./cl/... type-checks (final link fails only on expected llgo-specific symbols, unrelated to this diff). The DbgFlag* rename has no stale references anywhere in the repo.

Adjacent note (not in this diff): cl/union.go:158 panic for union alignment > 8 is prefixed [WARN] yet is fatal, unlike neighboring branches that degrade gracefully. Worth converting to a logged skip in a follow-up.

Comment thread cl/func.go Outdated
Comment thread cl/compile.go Outdated
@xushiwei xushiwei changed the title cl: tryToMethod bugfix cl: tryToMethod bugfix; conf.TypeSuffix Sep 30, 2026
@xushiwei
xushiwei merged commit ea6aa52 into goplus:main Sep 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant