Skip to content

mod: github.com/llarhub/clang-c v0.7.0; verify xgo-dev/llgo#2677 - #881

Merged
xushiwei merged 1 commit into
goplus:mainfrom
xushiwei:q
Sep 30, 2026
Merged

xushiwei merged 1 commit into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.04%. Comparing base (37ad384) to head (ea24b24).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #881   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files          22       22           
  Lines        1857     1857           
=======================================
  Hits         1635     1635           
  Misses        222      222           
Flag Coverage Δ
llgo-tests 88.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: bump clang-c to v0.7.0 + VisitChildren method-call refactor

This is a small, well-scoped dependency bump plus a mechanical refactor. The change is correct and low-risk. Verified locally: go build ./clang/... passes against v0.7.0.

What was verified

  • Refactor correctness (clang/clang.go:299-304): clang.VisitChildren(root, ...) → root.VisitChildren(...) resolves to the same underlying clang_visitChildren traversal. The closure signature func(cur, parent Cursor, param clang.ClientData) ChildVisitResult matches v0.7.0's CursorVisitor, and the exported wrapper signature is unchanged.
  • Blast radius: all call sites use the package-level clang.VisitChildren(...) wrapper (in cl/*.go, tool/dump.go), whose public API is untouched — no caller changes needed, and none were made.
  • Supply chain (go.sum): both v0.7.0 hashes verify against the public checksum DB; go.mod/go.sum are consistent.
  • Docs: the VisitChildren doc comment remains accurate; no update required.

Non-blocking note before merge

  • v0.7.0 also bundles an unrelated behavioral change — enum default switching from c.Int to c.Uint. This could subtly alter enum sign handling in generated bindings. Worth confirming downstream enum-generation tests still pass before merging. v0.7.0 was tagged the same day as this bump, so a quick CI-green confirmation on the new tag is prudent.

No blocking issues found.

@xushiwei
xushiwei merged commit 3d35306 into goplus:main Sep 30, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant