mod: github.com/llarhub/clang-c v0.7.0; verify xgo-dev/llgo#2677 - #881
Merged
Merged
Conversation
xushiwei
commented
Sep 30, 2026
Member
- link directive bug: can't use alias type as recv, callback as method param xgo-dev/llgo#2677
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
=======================================
Coverage 88.04% 88.04%
=======================================
Files 22 22
Lines 1857 1857
=======================================
Hits 1635 1635
Misses 222 222
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Review: bump clang-c to v0.7.0 + VisitChildren method-call refactor
This is a small, well-scoped dependency bump plus a mechanical refactor. The change is correct and low-risk. Verified locally: go build ./clang/... passes against v0.7.0.
What was verified
- Refactor correctness (
clang/clang.go:299-304):clang.VisitChildren(root, ...)→root.VisitChildren(...)resolves to the same underlyingclang_visitChildrentraversal. The closure signaturefunc(cur, parent Cursor, param clang.ClientData) ChildVisitResultmatches v0.7.0'sCursorVisitor, and the exported wrapper signature is unchanged. - Blast radius: all call sites use the package-level
clang.VisitChildren(...)wrapper (incl/*.go,tool/dump.go), whose public API is untouched — no caller changes needed, and none were made. - Supply chain (
go.sum): bothv0.7.0hashes verify against the public checksum DB;go.mod/go.sumare consistent. - Docs: the
VisitChildrendoc comment remains accurate; no update required.
Non-blocking note before merge
v0.7.0also bundles an unrelated behavioral change — enum default switching fromc.Inttoc.Uint. This could subtly alter enum sign handling in generated bindings. Worth confirming downstream enum-generation tests still pass before merging.v0.7.0was tagged the same day as this bump, so a quick CI-green confirmation on the new tag is prudent.
No blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.